Plugins can't be executed on Windows

[dsimansk]

Bug report

We use syscall.Exec() as underlying mechanism to execute plugins locally. However, syscall doesn't support Windows as target platform.

The very same problem resolved in kubectl.

client/pkg/kn/commands/plugin/handler.go

Lines 94 to 97 in db569fa

	// Execute implements PluginHandler
	func (h *DefaultPluginHandler) Execute(executablePath string, cmdArgs, environment []string) error {
	return syscall.Exec(executablePath, cmdArgs, environment)
	}

Expected behavior

kn plugins are executable on Windows.

kn version

HEAD

/kind good-first-issue

[MIBc]

We can refer to kubectl. I can help to do it.

[rhuss]

Cool, thanks ! I'll assign the issue to you

/assign MIBc

[maximilien]

I also wonder if there is a way to extend PROW to support any platform specific e2e tests execution? Would be useful for this issue (Windows) and the small differences between Mac OSX and Linux. For instance this issue Mac OS X-specific issue #733 will require a Mac to test.

I am going to open an issue to capture this problem. It’s not high-priority since we can trust the various contributors have done the tests but that clearly will not be a long term solution for automated CI.