fix(e2e): Remove "serving.knative.dev/route" revision label#1067
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Oct 15, 2020
Merged
fix(e2e): Remove "serving.knative.dev/route" revision label#1067knative-prow-robot merged 1 commit intoknative:masterfrom
knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
knative-prow-robot
added
approved
Dont expect mentioned key on the revision labels in service expect tests now. The test is skipped for serving v0.18 release and configured to only against current serving master. see #knative/serving#9710
navidshaikh
force-pushed
the
pr/fix-export-e2e
branch
from
6b02368 to
6e80254
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dont expect mentioned key on the revision labels in service
export tests now. The test is skipped for serving v0.18 release
and configured to only against current serving master.
see #knative/serving#9710
/cc @nak3 @maximilien @rhuss