adds --scale range option#1114
adds --scale range option#1114knative-prow-robot merged 2 commits intoknative:masterfrom mpetason:issue-822-pt3
Conversation
knative-prow-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
|
@mpetason Thanks a lot for all your work. Let's get that landed, I will give a review this week so that we finally be able to merge it. Thanks also for your patience. |
knative-prow-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, mpetason The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-knative-client-integration-tests |
|
It doesn't look like the failing test is associated with my changes. I'll try running it again on Monday. |
|
/test pull-knative-client-integration-tests |
|
/retest |
| return err | ||
| } | ||
| } else { | ||
| return fmt.Errorf("Scale must be of the format x..y or x") |
There was a problem hiding this comment.
| return fmt.Errorf("Scale must be of the format x..y or x") | |
| return fmt.Errorf("scale must be of the format x..y or x") |
There was a problem hiding this comment.
error messages should begin with lower case
There was a problem hiding this comment.
Should I make this edit and create a new PR, or commit suggestion? Not sure how it works after a merge.
6 participants
Description
Fixes #822
Changes
Reference
Fixes #822
Replaces previous PR where I had issues with a rebase - #1070
Replaces previous PR where I had issues with a rebase - #986