Skip to content

TestServiceExport works with images specified by digest#1435

Merged
knative-prow-robot merged 2 commits intoknative:mainfrom
mgencur:service_export_digest
Aug 30, 2021
Merged

TestServiceExport works with images specified by digest#1435
knative-prow-robot merged 2 commits intoknative:mainfrom
mgencur:service_export_digest

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented Aug 24, 2021 •
edited
Loading

Description

Images specified by digest are not set in user-image annotation. This PR corrects the test to work with image digest..

Changes

  • Do not expect user-image annotation to contain the image if the image is specified by digest.
  • Do not expect image name in the output of source list as it might not be available when images are passed as image digest.

Reference

Fixes #

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 24, 2021
knative-prow-robot
knative-prow-robot reviewed Aug 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgencur: 0 warnings.

Details

In response to this:

Description

Images specified by digest are not set in user-image annotation. This PR corrects the test to work with image digest..

Changes

  • Do not expect user-image annotation to contain the image if the image is specified by digest.

Reference

Fixes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 24, 2021 •
edited
Loading

Codecov Report

Merging #1435 (11cc35a) into main (e570844) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1435   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         162      162           
  Lines        8368     8368           
=======================================
  Hits         6586     6586           
  Misses       1098     1098           
  Partials      684      684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e570844...11cc35a. Read the comment docs.

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Aug 24, 2021

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@mgencur mgencur force-pushed the service_export_digest branch from c1f73f6 to 7125b66 Compare August 24, 2021 08:33
@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Aug 24, 2021

/hold cancel

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2021
@mgencur
Do not expect image name in TestSourceContainer test
11cc35a 
* it might not be available if the test image is passed as image digest
itsmurugappan
itsmurugappan approved these changes Aug 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsmurugappan itsmurugappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2021
@dsimansk
Copy link
Copy Markdown
Contributor

dsimansk commented Aug 30, 2021

Thanks @mgencur!

/approve
/lgtm

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, itsmurugappan, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@knative-prow-robot knative-prow-robot merged commit 95193bd into knative:main Aug 30, 2021
mgencur added a commit to mgencur/knative-client that referenced this pull request Aug 30, 2021
@mgencur
TestServiceExport works with images specified by digest (knative#1435)
2462a98 
* TestServiceExport works with images specified by digest

* Do not expect image name in TestSourceContainer test

* it might not be available if the test image is passed as image digest
@mgencur mgencur mentioned this pull request Aug 30, 2021
Merged
openshift-merge-robot pushed a commit to openshift/knative-client that referenced this pull request Aug 31, 2021
@mgencur
TestServiceExport works with images specified by digest (knative#1435) (
22aba44 
#794)

* TestServiceExport works with images specified by digest

* Do not expect image name in TestSourceContainer test

* it might not be available if the test image is passed as image digest
dsimansk pushed a commit to openshift/knative-client that referenced this pull request Sep 7, 2021
@mgencur @dsimansk
TestServiceExport works with images specified by digest (knative#1435)
3c70bd5 
* TestServiceExport works with images specified by digest

* Do not expect image name in TestSourceContainer test

* it might not be available if the test image is passed as image digest
dsimansk pushed a commit to openshift/knative-client that referenced this pull request Sep 30, 2021
@mgencur @dsimansk
TestServiceExport works with images specified by digest (knative#1435)
e3e3da9 
* TestServiceExport works with images specified by digest

* Do not expect image name in TestSourceContainer test

* it might not be available if the test image is passed as image digest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

+1 more reviewer

@itsmurugappan itsmurugappan itsmurugappan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsimansk dsimansk

@itsmurugappan itsmurugappan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgencur @dsimansk @knative-prow-robot @itsmurugappan