Update go.mod and go.sum by test/presubmit-tests.sh

[nak3]

This changes are updated by running test/presubmit-tests.sh against HEAD.

Fixes #163

[knative-prow-robot]

Hi @nak3. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

I wonder from where these indirect dependencies come from, as we don't change direct dependencies in this PR. Any ideas ?

[nak3]

I'm not exactly sure about the go mod's mechanism. But I am thinking that following code updates the dependencies.

client/vendor/github.com/knative/test-infra/scripts/library.sh

Line 370 in b6a8fa9

go get -u github.com/google/licenseclassifier

When I ran test/presubmit-tests.sh, the code is updated after this message.

-----------------------------------------
---- Checking for forbidden licenses ----
-----------------------------------------
go: finding github.com/google/licenseclassifier latest

[rhuss]

Ah, ok. That's probably also why there is an // indirect comment which indicates that the dependencies don't come directly by being used in the source. I thought it was only about transitive dependencies but looks like the same mechanism is used for dependencies coming from other sources (like this go get).

I really wished go mod would clearly separate the manual declared dependencies (or those suggested by examing the source code) from transitive dependencies, as Maven does.

Could we please remove the // indirect comment as often during the update I'm removing all // indirects and let go mod figure them out a fresh ? At the end, it's a direct dependency anyway for us.

[nak3]

Hmm... it looks like it is not possible. Even if we remove the // indirect comment manually from go.mod, it is added automatically whenever we run test/presubmit-tests.sh.

[rhuss]

ok, then may it be like this and I'm fine with the inevitable ;-)

/lgtm

[knative-prow-robot]

@rhuss: changing LGTM is restricted to assignees, and only knative/client repo collaborators may be assigned issues.

Details

In response to this:

ok, then may it be like this and I'm fine with the inevitable ;-)

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

/ok-to-test

[sixolet]

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, rhuss, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sixolet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment