Skip to content

WIP: Add the support to test against the previous release and the latest source#190

Closed
houshengbo wants to merge 1 commit intoknative:masterfrom
houshengbo:add-milestone-release-test1
Closed

WIP: Add the support to test against the previous release and the latest source#190
houshengbo wants to merge 1 commit intoknative:masterfrom
houshengbo:add-milestone-release-test1

Conversation

@houshengbo
Copy link
Copy Markdown

@houshengbo houshengbo commented Jun 17, 2019

No description provided.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 17, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 17, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: houshengbo
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cppforlife

If they are not already assigned, you can assign the PR to them by writing /assign @cppforlife in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2019
@houshengbo
Copy link
Copy Markdown
Author

houshengbo commented Jun 17, 2019

/retest

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 17, 2019

@houshengbo what the difference of this PR to #170 ?

@rhuss rhuss self-assigned this Jun 17, 2019
@houshengbo
Copy link
Copy Markdown
Author

houshengbo commented Jun 17, 2019

@rhuss I am just trying another way to fix this issue with a param to see 0.6.0 can really work with the pr build of integration test. Ignore this one.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2019
@houshengbo houshengbo closed this Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@rhuss rhuss

Labels

cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@houshengbo @knative-prow-robot @rhuss @googlebot