Skip to content

List revisions for a given service#194

Merged
knative-prow-robot merged 5 commits intoknative:masterfrom
navidshaikh:fix-127
Jun 20, 2019
Merged

List revisions for a given service#194
knative-prow-robot merged 5 commits intoknative:masterfrom
navidshaikh:fix-127

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Jun 19, 2019

Fixes #127

kn revision list
SERVICE   NAME          AGE     CONDITIONS   READY   REASON
hello     hello-dfc7p   109m    4 OK / 5     True    
hello     hello-h9qdr   20h     4 OK / 5     True    
svc1      svc1-ksds5    7m11s   4 OK / 5     True    

kn revision list -s svc1
SERVICE   NAME         AGE     CONDITIONS   READY   REASON
svc1      svc1-ksds5   7m15s   4 OK / 5     True    

kn revision list -s hello
SERVICE   NAME          AGE    CONDITIONS   READY   REASON
hello     hello-dfc7p   109m   4 OK / 5     True    
hello     hello-h9qdr   20h    4 OK / 5     True

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 19, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 19, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 19, 2019

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2019
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Jun 19, 2019

/ok-to-test

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 19, 2019

@navidshaikh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 19, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2019
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 19, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/revision/revision_list.go 80.0% 81.2% 1.2
pkg/kn/commands/revision/revision_list_flags.go 46.7% 52.9% 6.3

@sixolet
Copy link
Copy Markdown
Contributor

sixolet commented Jun 20, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@knative-prow-robot knative-prow-robot merged commit 9c865a6 into knative:master Jun 20, 2019
rhuss
rhuss reviewed Jun 21, 2019
View reviewed changes
Comment thread pkg/kn/commands/revision/revision_list.go
return err
}
listOptions.LabelSelector = labels.Set(
map[string]string{serving.ConfigurationLabelKey: service}).String()
Copy link
Copy Markdown
Contributor

@rhuss rhuss Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be serving.ServiceLabelKey ? Don't really see how this is tested in the tests, too ...

Copy link
Copy Markdown
Contributor Author

@navidshaikh navidshaikh Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I checked an actual revision and both the keys in labels are holding service name

                "labels": {
                    "serving.knative.dev/configuration": "svc1",
                    "serving.knative.dev/configurationGeneration": "1",
                    "serving.knative.dev/service": "svc1"
                },

@rhuss : I will need to check among 2 labels, which one we should filter against.

in tests here.

Copy link
Copy Markdown
Contributor

@rhuss rhuss Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't the service label the authorative answer for which revision belongs to which service and the configuration is just (by accident) named like the service because it has been created implicitely ? Or does the configuration alway be named like the service ? (I don't think so)

maximilien pushed a commit to maximilien/client that referenced this pull request Jul 1, 2019
@navidshaikh @maximilien
List revisions for a given service (knative#194)
375ecbd 
* Lists revisions for a given service

 Fixes knative#127

* Adds unit tests for listing revisions of a service

* Adds integration tests for listing revisions of a service

* Updates docs for listing revisions of a service

* Updates vendor/modules.txt
@navidshaikh navidshaikh deleted the fix-127 branch November 18, 2019 12:38
navidshaikh added a commit to navidshaikh/client that referenced this pull request Dec 11, 2019
@navidshaikh @openshift-merge-robot
Use hack/install.sh from serverless-operator repo (knative#194)
8c149a2 
* Use hack/install.sh from serverless-operator repo

 - To configure serverless-operator, knative-serving and dependencies.
 - Unset OPENSHIFT_BUILD_NAMESPACE env var as its used by serverless-operator in its own CI to use the CI built images for k-s-o and k-o-i, client uses pre-built images

* Rename install_serverless_operator to install_serverless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@sixolet sixolet Awaiting requested review from sixolet

1 more reviewer

@rhuss rhuss rhuss left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sixolet sixolet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

List revisions for given service

6 participants

@navidshaikh @knative-prow-robot @rhuss @knative-metrics-robot @sixolet @googlebot