Skip to content

Fixes limits-memory and requests-memory descriptions#198

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
maximilien:patch-1
Jun 28, 2019
Merged

Fixes limits-memory and requests-memory descriptions#198
knative-prow-robot merged 2 commits intoknative:masterfrom
maximilien:patch-1

Conversation

@maximilien
Copy link
Copy Markdown
Contributor

@maximilien maximilien commented Jun 22, 2019

Erroneously showed ‘CPU’ for ‘memory’ in description strings

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2019
rhuss
rhuss approved these changes Jun 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 22, 2019

/lgtm

the test failure is a general build failure affecting every PR. I'm on it.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2019
@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 22, 2019

/approve

@mattmoor mattmoor removed their request for review June 23, 2019 15:58
navidshaikh
navidshaikh suggested changes Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update (auto-generated) docs for service create and service update.

@adrcunha
Copy link
Copy Markdown
Contributor

adrcunha commented Jun 24, 2019

/retest

1 similar comment
@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Jun 24, 2019

/retest

@maximilien
Copy link
Copy Markdown
Contributor Author

maximilien commented Jun 27, 2019

Please also update (auto-generated) docs for service create and service update.

OK doing this now. Sorry for the delay.

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2019
@maximilien
Fixes limits-memory and requests-memory descriptions
31f917e 
Erroneously showed ‘CPU’ for ‘memory’ in description strings
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2019
@maximilien
Copy link
Copy Markdown
Contributor Author

maximilien commented Jun 27, 2019

Done: @navidshaikh @rhuss

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss rhuss mentioned this pull request Jun 27, 2019
Closed
@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 27, 2019

The test are flaky

Failed to successfully execute 'kn service update hello --env TARGET=kn -n kne2etests': Execution error: stderr: 'Operation cannot be fulfilled on services.serving.knative.dev "hello": the object has been modified; please apply your changes to the latest version and try again
' error: 'exit status 1'FAIL	github.com/knative/client/test/e2e	1.792s

Let's track that in #100 It looks either a timing issue or indeed an error on our side, that we don't read the service to update before updating or doing something wrong here.

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 27, 2019

/retest pull-knative-client-integration-tests

2 similar comments
@cppforlife
Copy link
Copy Markdown

cppforlife commented Jun 27, 2019

/retest pull-knative-client-integration-tests

@cppforlife
Copy link
Copy Markdown

cppforlife commented Jun 28, 2019

/retest pull-knative-client-integration-tests

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Jun 28, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019
@knative-prow-robot knative-prow-robot merged commit 43b37a6 into knative:master Jun 28, 2019
maximilien added a commit to maximilien/client that referenced this pull request Jul 1, 2019
@maximilien
Fixes limits-memory and requests-memory descriptions (knative#198)
316d65b 
Erroneously showed ‘CPU’ for ‘memory’ in description strings
@maximilien maximilien deleted the patch-1 branch July 1, 2019 12:51
dsimansk pushed a commit to dsimansk/client that referenced this pull request Jul 10, 2023
@Kaustubh-pande
[SRVOCF-477] add default s2i builders. (knative#198)
e7b3c4d 
* [SRVOCF-477] add default s2i builders

* update correct path of variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cppforlife cppforlife Awaiting requested review from cppforlife

2 more reviewers

@rhuss rhuss rhuss approved these changes

@navidshaikh navidshaikh navidshaikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rhuss rhuss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@maximilien @rhuss @adrcunha @chizhg @knative-prow-robot @cppforlife @navidshaikh @googlebot