Add kn revision delete command by navidshaikh · Pull Request #207 · knative/client

navidshaikh · 2019-06-25T10:37:24Z

Fixes #203

➜  client git:(fix-203)  ./kn revision list
SERVICE   NAME          AGE     CONDITIONS   READY     REASON
hello     hello-2krsg   4s      1 OK / 5     Unknown   Deploying
hello     hello-7w8z7   47m     4 OK / 5     True      
kn1       kn1-kcwt7     9m23s   4 OK / 5     True      
svc1      svc1-j7hqr    23h     4 OK / 5     True      

➜  client git:(fix-203)  ./kn revision delete hello-7w8z7
Revision 'hello-7w8z7' successfully deleted in namespace 'default'.

➜  client git:(fix-203)  ./kn revision list              
SERVICE   NAME          AGE     CONDITIONS   READY   REASON
hello     hello-2krsg   16s     5 OK / 5     True    
kn1       kn1-kcwt7     9m35s   4 OK / 5     True    
svc1      svc1-j7hqr    23h     4 OK / 5     True

knative-prow-robot · 2019-06-25T10:37:39Z

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

navidshaikh · 2019-06-25T10:44:25Z

/ok-to-test

knative-prow-robot · 2019-06-25T10:44:52Z

@navidshaikh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sixolet · 2019-06-25T17:14:14Z

/ok-to-test

rhuss · 2019-06-25T17:26:34Z

Is think there's a race in the test

Running 'kn service update hello --env TARGET=kn -n kne2etests'...
Failed to successfully execute 'kn service update hello --env TARGET=kn -n kne2etests': Execution error: stderr: 'Operation cannot be fulfilled on services.serving.knative.dev "hello": the object has been modified; please apply your changes to the latest version and try again
' error: 'exit status 1'FAIL	github.com/knative/client/test/e2e	0.528s

rhuss · 2019-06-25T17:27:19Z

Or update is broken.

maximilien

Unit and integration tests?

navidshaikh · 2019-06-26T10:47:38Z

@maximilien : Thanks for review, I've updated the PR with unit and integration tests (added TestRevisionWorkflow, as IMO this isn't basic workflow).

navidshaikh · 2019-06-26T11:30:09Z

Is think there's a race in the test

@rhuss : Yup, in this e2e run TestBasicWorkflow passed.
`

Added revision delete command tests in new workflow namely TestRevisionWorkflow.

Also adds check for 'No resources found' while grabbing revision name.

rhuss · 2019-06-28T14:49:34Z

Oops, test failures ;-(

navidshaikh · 2019-06-28T15:02:04Z

/retest

rhuss

Some minor nit-picks, otherwise looks fine for me. Thanks !

navidshaikh · 2019-06-28T16:20:24Z

@rhuss : Thanks for the review, updated the PR, PTAL.

rhuss · 2019-06-28T16:23:18Z

# github.com/knative/client/test/e2e [github.com/knative/client/test/e2e.test]
test/e2e/revision_workflow_test.go:20:2: imported and not used: "fmt"

rhuss · 2019-06-28T16:32:39Z

+	} else if name != revName {
+		t.Errorf("Bad revision name returned after delete.")
+	}
+	commands.TestContains(t, output, []string{"Revision", revName, "deleted", "namespace", commands.FakeNamespace}, "word in output")


knative-prow-robot · 2019-06-28T16:36:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-metrics-robot · 2019-06-28T16:41:50Z

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/revision/delete.go	Do not exist	75.0%

rhuss · 2019-06-28T17:20:05Z

/lgtm

* Adds kn revision delete command * Adds unit tests for revision delete command * Adds integration tests for revision delete command Added revision delete command tests in new workflow namely TestRevisionWorkflow. * Removes extra line and renames an import alias * Adds 10 seconds sleep between service create and revision delete Also adds check for 'No resources found' while grabbing revision name. * Clean up imports * Removes the pause after service create * Updates testing output strings in unit and e2e * Updates post goimports on hack and test dirs

knative-prow-robot requested review from cppforlife and evankanderson June 25, 2019 10:37

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 25, 2019

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2019

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 25, 2019

navidshaikh changed the title ~~Adds kn revision delete command~~ Add kn revision delete command Jun 25, 2019

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2019

maximilien reviewed Jun 26, 2019

View reviewed changes

Comment thread pkg/kn/commands/revision/delete.go

maximilien suggested changes Jun 26, 2019

View reviewed changes

navidshaikh force-pushed the fix-203 branch from 76e5a90 to 3432262 Compare June 26, 2019 10:46

navidshaikh mentioned this pull request Jun 27, 2019

Operation 'service update' failing in e2e tests #211

Closed

navidshaikh added 6 commits June 28, 2019 19:59

Adds kn revision delete command

5977d83

Adds unit tests for revision delete command

2b70903

Adds integration tests for revision delete command

c2d9b96

Added revision delete command tests in new workflow namely TestRevisionWorkflow.

Removes extra line and renames an import alias

9805bb3

Adds 10 seconds sleep between service create and revision delete

2debc55

Also adds check for 'No resources found' while grabbing revision name.

Clean up imports

8c8703e

navidshaikh force-pushed the fix-203 branch from 65b194a to 8c8703e Compare June 28, 2019 14:30

Removes the pause after service create

ac84611

rhuss suggested changes Jun 28, 2019

View reviewed changes

rhuss self-assigned this Jun 28, 2019

Updates testing output strings in unit and e2e

74d8c06

rhuss approved these changes Jun 28, 2019

View reviewed changes

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2019

Updates post goimports on hack and test dirs

adc2704

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019

knative-prow-robot merged commit 65f1c08 into knative:master Jun 28, 2019

navidshaikh deleted the fix-203 branch November 18, 2019 12:38

Conversation

navidshaikh commented Jun 25, 2019

Uh oh!

knative-prow-robot commented Jun 25, 2019

Uh oh!

navidshaikh commented Jun 25, 2019

Uh oh!

knative-prow-robot commented Jun 25, 2019

Uh oh!

sixolet commented Jun 25, 2019

Uh oh!

rhuss commented Jun 25, 2019

Uh oh!

rhuss commented Jun 25, 2019

Uh oh!

Uh oh!

maximilien left a comment

Choose a reason for hiding this comment

Uh oh!

navidshaikh commented Jun 26, 2019

Uh oh!

navidshaikh commented Jun 26, 2019

Uh oh!

rhuss commented Jun 28, 2019

Uh oh!

navidshaikh commented Jun 28, 2019

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

navidshaikh commented Jun 28, 2019

Uh oh!

rhuss commented Jun 28, 2019

Uh oh!

rhuss Jun 28, 2019

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Jun 28, 2019

Uh oh!

knative-metrics-robot commented Jun 28, 2019

Uh oh!

rhuss commented Jun 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants