Skip to content

Add rhuss and maximilien to OWNERS to increase approver speed.#209

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
sixolet:owners
Jun 26, 2019
Merged

Add rhuss and maximilien to OWNERS to increase approver speed.#209
knative-prow-robot merged 1 commit intoknative:masterfrom
sixolet:owners

Conversation

@sixolet
Copy link
Copy Markdown
Contributor

@sixolet sixolet commented Jun 26, 2019

Top two committers in the last while who also participate in WG meetings regularly.

@sixolet sixolet requested a review from cppforlife June 26, 2019 22:10
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 26, 2019
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2019
@sixolet
Copy link
Copy Markdown
Contributor Author

sixolet commented Jun 26, 2019

/retest

@cppforlife
Copy link
Copy Markdown

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit d4c2d4a into knative:master Jun 26, 2019
maximilien pushed a commit to maximilien/client that referenced this pull request Jul 1, 2019
Kaustubh-pande added a commit to Kaustubh-pande/client that referenced this pull request Aug 8, 2023
Co-authored-by: Kaustubh Pande <kaustubhpande.kp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants