feature: --no-headers flag for resource listing by komaldhull · Pull Request #262 · knative/client

komaldhull · 2019-07-12T15:03:14Z

Adds support for a "--no-headers" flag for resource listing commands that prints the default table output with column headers removed

Fixes #233

Release notes

--no-headers flag for resource listing

googlebot · 2019-07-12T15:03:17Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

knative-prow-robot

@komaldhull: 0 warnings.

Details

In response to this:

Adds support for a "--no-headers" flag for resource listing commands that prints the default table output with column headers removed

Fixes #233

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2019-07-12T15:03:29Z

Hi @komaldhull. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhuss · 2019-07-12T17:24:01Z

/ok-to-test

rhuss

Thanks ! will give a review on Monday, but could you please remove the .DS_Store file that you accidentally checked in ? (and please squash then to remove it from any commit)

rhuss · 2019-07-13T10:18:23Z

@komaldhull : Also you would need to sign the google CLA. Thanks !

rhuss · 2019-07-15T18:16:39Z

/retest

rhuss

looks good with some nit-pick.

Now checking why the test failed.

rhuss · 2019-07-16T14:08:50Z

/retest

There is yet another flaky test introduced which checks for a revision to be ready too fast.

rhuss · 2019-07-16T14:09:59Z

@komaldhull could you squash you commits to a single commit ? It looks like that one of your current commits uses an email that is not CLAed. If you squash with your current account which has signed an CLA, and force push, then the CLA check should be happy.

rhuss · 2019-07-16T14:50:59Z

Hmm, CLA check still failing ;-( Can you please check that you did the steps in #262 (comment) ? Probably as an corporate signer under IBM ?

If this is fixed, we are good to merge.

komaldhull · 2019-07-16T15:20:21Z

looks like my request to be added as an IBM contributor is still pending :( just followed up so I should be added soon, I'll comment when I hear back.

komaldhull · 2019-07-17T13:02:34Z

@rhuss I should be added to the CLA now!

googlebot · 2019-07-17T13:02:37Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cppforlife · 2019-07-22T17:38:55Z

waiting on #284 vs #283

navidshaikh · 2019-08-16T06:10:18Z

ping @komaldhull Can you update PR following recent changes to bool flags as referenced above?

komaldhull · 2019-08-28T01:21:44Z

@navidshaikh my apologies for not seeing this earlier! could you please clarify what requires changing to meet the conventions? as far as I can tell, this PR matches the documentation (the default behavior is to print headers, so adding the flag "--no-headers" disables the headers), sorry if I'm missing something.

navidshaikh · 2019-08-28T08:48:28Z

@komaldhull : I think the current flag --no-headers looks good. Can you resolve the conflicts and rebase ?

knative-metrics-robot · 2019-09-02T18:54:14Z

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/service_list_flags.go	46.7%	50.0%	3.3

navidshaikh · 2019-09-03T07:29:34Z

/hold cancel

navidshaikh

/lgtm
/approve

knative-prow-robot · 2019-09-03T07:30:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: komaldhull, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jul 12, 2019

knative-prow-robot reviewed Jul 12, 2019

View reviewed changes

knative-prow-robot requested review from evankanderson and sixolet July 12, 2019 15:03

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 12, 2019

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2019

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2019

rhuss suggested changes Jul 13, 2019

View reviewed changes

komaldhull force-pushed the noheaders branch from 50bf2f2 to f64fa50 Compare July 15, 2019 03:01

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2019

komaldhull force-pushed the noheaders branch from f64fa50 to 83cfe18 Compare July 15, 2019 03:18

knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2019

navidshaikh suggested changes Jul 15, 2019

View reviewed changes

Comment thread docs/cmd/kn_revision_list.md Outdated

Comment thread docs/cmd/kn_service_list.md Outdated

Comment thread docs/cmd/kn_route_list.md Outdated

Comment thread pkg/kn/commands/revision/revision_list_test.go Outdated

Comment thread pkg/kn/commands/revision/revision_list_test.go Outdated

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2019

rhuss suggested changes Jul 15, 2019

View reviewed changes

Comment thread pkg/kn/commands/human_readable_flags.go Outdated

navidshaikh approved these changes Jul 16, 2019

View reviewed changes

Comment thread pkg/kn/commands/service/service_list_test.go

komaldhull force-pushed the noheaders branch from e942843 to 5fae74d Compare July 16, 2019 14:28

googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jul 17, 2019

cppforlife added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019

Added --no-headers flag for resource listing

59d1a62

komaldhull force-pushed the noheaders branch from 5fae74d to 59d1a62 Compare September 2, 2019 18:51

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2019

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2019

navidshaikh approved these changes Sep 3, 2019

View reviewed changes

knative-prow-robot assigned navidshaikh Sep 3, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019

knative-prow-robot merged commit 6790961 into knative:master Sep 3, 2019

Conversation

komaldhull commented Jul 12, 2019 • edited by navidshaikh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release notes

Uh oh!

googlebot commented Jul 12, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

knative-prow-robot left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Jul 12, 2019

Uh oh!

rhuss commented Jul 12, 2019

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

rhuss commented Jul 13, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rhuss commented Jul 15, 2019

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rhuss commented Jul 16, 2019

Uh oh!

rhuss commented Jul 16, 2019

Uh oh!

rhuss commented Jul 16, 2019

Uh oh!

komaldhull commented Jul 16, 2019

Uh oh!

komaldhull commented Jul 17, 2019

Uh oh!

googlebot commented Jul 17, 2019

Uh oh!

cppforlife commented Jul 22, 2019

Uh oh!

navidshaikh commented Aug 16, 2019

Uh oh!

komaldhull commented Aug 28, 2019

Uh oh!

navidshaikh commented Aug 28, 2019

Uh oh!

knative-metrics-robot commented Sep 2, 2019

Uh oh!

navidshaikh commented Sep 3, 2019

Uh oh!

navidshaikh left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

komaldhull commented Jul 12, 2019 •

edited by navidshaikh

Loading