chore(revision): Remove unwanted log message in test#267
chore(revision): Remove unwanted log message in test#267knative-prow-robot merged 2 commits intoknative:masterfrom
Conversation
This showed up in the test run as single log message so I removed that.
knative-prow-robot
added
approved
|
/retest |
| TypeMeta: metav1.TypeMeta{ | ||
| Kind: "Revision", | ||
| APIVersion: "knative.dev/v1alpha1", | ||
| APIVersion: "serving.knative.dev/v1alpha1", |
There was a problem hiding this comment.
The change seems to be at odd with the title...
There was a problem hiding this comment.
The test is broken, as it does not break because of the wrong coordinates (in fact it the api group is serving.knative.dev/v1alpha1, it's just not checked in this test, so it's meaningless anyway.
Happy to revert back to the wrong coordinates though.
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
Can you change title to reflect change and 'll approve and lgtm
|
Reverted the unrelated fix, and will send in a new PR with fixes for all test with a broken API group |
rhuss
changed the title
|
/retest |
1 similar comment
|
/retest |
|
/retest The flaky test should be fixed with #271 . |
|
/retest |
|
Guess we have to wait until #271 is merged to get the test green again. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cppforlife, navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
6 participants
This showed up in the test run as single log message so removing it