Improves(e2e): improves integration tests and to better run locally#274
Merged
knative-prow-robot merged 3 commits intoknative:masterfrom Jul 23, 2019
Merged
Improves(e2e): improves integration tests and to better run locally#274knative-prow-robot merged 3 commits intoknative:masterfrom
knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
1. refactors basic workflow (move code to common) 2. use different namespace accross test runs to isolate 3. include wait logic in CreateNamespace to allow multiple runs 4. include wait logic in DeleteNamespace to allow multiple runs This is important since we need more integration tests and some of these changes should allow `./test/e2e-tests-local.sh` to run on local clusters (minikube or something other than test-infra) and correctly behave during mutiple runs.
knative-prow-robot
added
approved
rhuss
suggested changes
Jul 19, 2019
Contributor
rhuss
left a comment
rhuss
left a comment
There was a problem hiding this comment.
- You (accidentally ?) reverted one of the last commits. Please revert the revert ;-)
- The login for creating the namespace with retries is broken imo. Please check.
- To avoid boolean flags I suggest a different approach (see comments)
Contributor
Author
Contributor
Author
|
/test pull-knative-client-integration-tests-latest-release |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Fails because of async update, fixed with #271 . The test should be fixed as soon as this PR is merged. Nevertheless, trying |
Contributor
Author
Contributor
Author
|
OK updated @rhuss. Let's see if all tests go green |
Contributor
|
/lgtm |
dsimansk
added a commit
to dsimansk/client
that referenced
this pull request
Oct 3, 2023
…native#274) * Fix plugin inlining that uses client-pkg dependency * Move list merge into plugin manager * Fix imports formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves integration tests and to better run locally
Fixes #273
Proposed Changes
CreateNamespaceto allow multiple runsDeleteNamespaceto allow multiple runsRelease Note