Skip to content

fix(bug) correct response for unknown command or plugin fixes(#309)#322

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
maximilien:issue309
Aug 5, 2019
Merged

fix(bug) correct response for unknown command or plugin fixes(#309)#322
knative-prow-robot merged 1 commit intoknative:masterfrom
maximilien:issue309

Conversation

@maximilien
Copy link
Copy Markdown
Contributor

➜  client git:(issue309) ✗ ./kn lol
Manage your Knative building blocks:
* Serving: Manage your services and release new software to them.
* Eventing: Manage event subscriptions and channels. Connect up event sources.

Usage:
...
Use "kn [command] --help" for more information about a command.

unknown sub-command or plugin "lol" for "kn"

Fixes #309

Proposed Changes

  • add better message if kn is called with unknown command or plugin

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 31, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2019
…#309)

```bash
➜  client git:(issue309) ✗ ./kn lol
Manage your Knative building blocks:
* Serving: Manage your services and release new software to them.
* Eventing: Manage event subscriptions and channels. Connect up event sources.

Usage:
...
Use "kn [command] --help" for more information about a command.

unknown sub-command or plugin "lol" for "kn"
```
@maximilien
Copy link
Copy Markdown
Contributor Author

maximilien commented Jul 31, 2019

/assign @rhuss

As he was already reviewing solutions to #309

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/core/root.go 56.5% 55.2% -1.3

@maximilien
Copy link
Copy Markdown
Contributor Author

/test pull-knative-client-integration-tests-latest-release

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Aug 5, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@knative-prow-robot knative-prow-robot merged commit 32470ac into knative:master Aug 5, 2019
@maximilien maximilien deleted the issue309 branch December 20, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unknown plugins or commands do not show help and correct message to user

5 participants