removes zsh completion since it does not work (fixes #426)

[maximilien]

Fixes #426

Proposed Changes

• removes zsh completion as it the code it generates does not work

• 🧽 Update or clean up current behaviour

[maximilien]

/ok-to-test

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/completion.go	85.7%	100.0%	14.3

[rhuss]

Looks good to me, but I wonder why would not remove all completions as I think bash completion is also not very helpful (for the reasons mentioned in #426 (comment)). Now it might be even more confusing and raising the question, why bash-completion and not zsh ?

[navidshaikh]

This works for zsh #443.

[maximilien]

Looks good to me, but I wonder why would not remove all completions as I think bash completion is also not very helpful (for the reasons mentioned in #426 (comment)). Now it might be even more confusing and raising the question, why bash-completion and not zsh ?

Fair. I don't care for BASH completion either. However, I believe @sixolet added it with her first commit. Care to chime in? Keep or scrap BASH completion too?

[maximilien]

@rhuss separating BASH completion removal discussions with issue #456.

So if this LGTY then please merge. Thanks.

[rhuss]

#443 make zsh completion working again (if we don't use [ in our help messages), but I would be happy to also remove it for now (so merging this PR, but still updating via #443)

@navidshaikh wdyt ?

[navidshaikh]

@rhuss : Sure lets merge this PR since the feature is not usable now. We can conclude on #443 and add it again.

[navidshaikh]

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[navidshaikh]

/test pull-knative-client-integration-tests