Skip to content

Adds zsh completion#476

Merged
knative-prow-robot merged 4 commits into
knative:masterfrom
navidshaikh:pr/revert-zsh-completion
Nov 5, 2019
Merged

Adds zsh completion#476
knative-prow-robot merged 4 commits into
knative:masterfrom
navidshaikh:pr/revert-zsh-completion

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Nov 5, 2019

Fixes #456

Proposed Changes

  • Adds back zsh completion after vendoring cobra library with a fix
  • Updates the command definition to accept argument either of ['bash', 'zsh']
  • Moves the completion command definition under pkg/kn/commands/completion
  • Updates docs
  • Updates CHANGELOG

/lint

@navidshaikh
Adds zsh completion
d8d81cd 
 - Adds back zsh completion after vendoring cobra library with a fix
 - Updates the command definition to accept argument either of ['bash', 'zsh']
 - Moves the completion command definition under `pkg/kn/commands/completion`
 - Updates docs
 - Updates CHANGELOG.adoc
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 5, 2019
knative-prow-robot
knative-prow-robot reviewed Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 1 warning.

Details

In response to this:

Fixes #456

Proposed Changes

  • Adds back zsh completion after vendoring cobra library with a fix
  • Updates the command definition to accept argument either of ['bash', 'zsh']
  • Moves the completion command definition under pkg/kn/commands/completion
  • Updates docs
  • Updates CHANGELOG

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread pkg/kn/commands/completion/completion.go
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 5, 2019

/lint

knative-prow-robot
knative-prow-robot reviewed Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 0 warnings.

Details

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Nov 5, 2019

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/completion/completion.go Do not exist 100.0%

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Nov 5, 2019

Looks good to me.

I added #477 to not forget that we should reintroduce the completion command to the help message, too (or at least discuss this).

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@navidshaikh navidshaikh added this to the v0.10.0 milestone Nov 5, 2019
@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Nov 5, 2019

/retest

@knative-prow-robot knative-prow-robot merged commit 44dafbd into knative:master Nov 5, 2019
@navidshaikh navidshaikh deleted the pr/revert-zsh-completion branch July 6, 2020 11:40
dsimansk added a commit to dsimansk/client that referenced this pull request Nov 5, 2024
@openshift-cherrypick-robot @dsimansk
Add generate target to makefile (knative#476)
6135ad2 
Co-authored-by: David Simansky <dsimansk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@cppforlife cppforlife Awaiting requested review from cppforlife

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@rhuss rhuss

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.10.0

Development

Successfully merging this pull request may close these issues.

Is BASH completion needed and useful?

5 participants

@navidshaikh @knative-prow-robot @knative-metrics-robot @rhuss @googlebot