Skip to content

Add completion to help message#478

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
navidshaikh:pr/477
Nov 12, 2019
Merged

Add completion to help message#478
knative-prow-robot merged 1 commit into
knative:masterfrom
navidshaikh:pr/477

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

Fixes #477

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 5, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/completion/completion.go Do not exist 100.0%

@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented Nov 5, 2019

Thanks! Looks good to me, but please let's check whether we should do it as we intentionally removed it with #263

How do folks feel to include kn completion again in the top-level kn help output?

My take is, that we should add it with this PR and not treat it as a magic gem (especially as we are advertising it on our main README, which is another topic on its own). Since we have now more top-level commands (and more to come with source and trigger), I think it's not so disturbing anymore.

Copy link
Copy Markdown
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this goes after Zsh completion is added again?

Comment thread docs/cmd/kn_completion.md Outdated
### Synopsis


This command prints shell completion code which need to be evaluated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*"which needs"

Copy link
Copy Markdown
Contributor

@rhuss rhuss Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This command prints shell completion code which need to be evaluated
This command prints shell completion code which needs to be evaluated

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get that merged.
@navidshaikh if you just fix this minor typo, then I will do a lgtm right after.

Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@knative-prow-robot knative-prow-robot merged commit c4a9197 into knative:master Nov 12, 2019
@navidshaikh navidshaikh deleted the pr/477 branch July 6, 2020 11:49
dsimansk added a commit to dsimansk/client that referenced this pull request Nov 5, 2024
Co-authored-by: David Simansky <dsimansk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "completion" to help message (again)

6 participants