Skip to content

Uses BYO revision names for traffic splitting e2e tests#506

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
navidshaikh:pr/fix-500-2
Nov 15, 2019
Merged

Uses BYO revision names for traffic splitting e2e tests#506
knative-prow-robot merged 2 commits intoknative:masterfrom
navidshaikh:pr/fix-500-2

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Nov 15, 2019 •
edited
Loading

Fixes #500

Proposed Changes

  • Uses BYO revision names for traffic splitting e2e tests
  • Avoid getting the revision name after service create/update using LCR or LRR from service status
  • Pauses 3 seconds before verifying actual vs expected traffic targets ( Check the comment on e2e test failed #500 (comment))

/lint

@navidshaikh
Uses BYO revision names for traffic splitting e2e tests
d42427c 
 - Avoid getting the revision name after service create/update using LCR or LRR from service status
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 15, 2019
knative-prow-robot
knative-prow-robot reviewed Nov 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 0 warnings.

Details

In response to this:

Related to #500

Proposed Changes

  • Uses BYO revision names for traffic splitting e2e tests
  • Avoid getting the revision name after service create/update using LCR or LRR from service status

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 15, 2019
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 15, 2019

/test pull-knative-client-integration-tests-latest-release

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 15, 2019

/test pull-knative-client-integration-tests

2 similar comments
@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 15, 2019

/test pull-knative-client-integration-tests

@navidshaikh
Copy link
Copy Markdown
Contributor Author

navidshaikh commented Nov 15, 2019

/test pull-knative-client-integration-tests

@navidshaikh navidshaikh mentioned this pull request Nov 15, 2019
Closed
@navidshaikh navidshaikh requested review from rhuss and sixolet November 15, 2019 15:33
@navidshaikh navidshaikh mentioned this pull request Nov 15, 2019
Merged
navidshaikh
navidshaikh commented Nov 15, 2019
View reviewed changes
Comment thread test/e2e/traffic_split_test.go
maximilien
maximilien approved these changes Nov 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1bcec16 into knative:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@cppforlife cppforlife Awaiting requested review from cppforlife

@sixolet sixolet Awaiting requested review from sixolet

@rhuss rhuss Awaiting requested review from rhuss

+1 more reviewer

@maximilien maximilien maximilien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maximilien maximilien

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

e2e test failed

4 participants

@navidshaikh @knative-prow-robot @maximilien @googlebot