Skip to content

tests: Use mock kn client tests for service list and delete#527

Merged
knative-prow-robot merged 5 commits intoknative:masterfrom
itsmurugappan:master
Nov 29, 2019
Merged

tests: Use mock kn client tests for service list and delete#527
knative-prow-robot merged 5 commits intoknative:masterfrom
itsmurugappan:master

Conversation

@itsmurugappan
Copy link
Copy Markdown
Contributor

@itsmurugappan itsmurugappan commented Nov 28, 2019 •
edited
Loading

Fixes #358

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 28, 2019
knative-prow-robot
knative-prow-robot reviewed Nov 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmurugappan: 0 warnings.

Details

In response to this:

Fixes #358

Proposed Changes

  • Refactors the delete service unit tests to use knclient mock
  • Partially fixes #358

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 28, 2019

Hi @itsmurugappan. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2019
@navidshaikh
Copy link
Copy Markdown
Contributor

navidshaikh commented Nov 29, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2019
navidshaikh
navidshaikh suggested changes Nov 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

I've added few comments, rest lgtm

  • We should also rename service_delete_mock_tests.go to delete_mock_tests.go

Comment thread pkg/kn/commands/service/list_mock_test.go Outdated
Comment thread pkg/kn/commands/service/list_mock_test.go Outdated
Comment thread pkg/kn/commands/service/list_mock_test.go Outdated
@navidshaikh navidshaikh changed the title Tests: refactor delete service unit test with mock kn client tests: Use mock kn client tests for service list and delete Nov 29, 2019
navidshaikh
navidshaikh approved these changes Nov 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thank you!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmurugappan, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2019
@navidshaikh
Copy link
Copy Markdown
Contributor

navidshaikh commented Nov 29, 2019

/retest

@knative-prow-robot knative-prow-robot merged commit b64f70c into knative:master Nov 29, 2019
dsimansk added a commit to dsimansk/client that referenced this pull request Nov 20, 2024
@dsimansk
Add dockerfile patch to latest images (knative#527)
6b0471c 
* Add dockerfile patch to latest images

* Fix label

* Test ga registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

+1 more reviewer

@navidshaikh navidshaikh navidshaikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@navidshaikh navidshaikh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor service unit tests to use KnClient mock framework

4 participants

@itsmurugappan @knative-prow-robot @navidshaikh @googlebot