Skip to content

Delete k8s cluster resource in e2e test#596

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:dev-e2e
Jan 6, 2020
Merged

Delete k8s cluster resource in e2e test#596
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:dev-e2e

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Jan 6, 2020 •
edited
Loading

Fixes #576

Proposed Changes

  • Delete k8s cluster resource: clusterrole, clusterrolebinding after e2e test finish.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 6, 2020
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 6, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 6, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 6, 2020
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 6, 2020

/assign @mattmoor

@navidshaikh
Copy link
Copy Markdown
Contributor

navidshaikh commented Jan 6, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2020
navidshaikh
navidshaikh approved these changes Jan 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks!
I've added a few suggestions, can be addressed in a subsequent PR as well.

Comment thread test/e2e/source_apiserver_test.go
Comment thread test/e2e/source_apiserver_test.go
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@knative-prow-robot knative-prow-robot merged commit e0877da into knative:master Jan 6, 2020
@MIBc MIBc deleted the dev-e2e branch January 7, 2020 01:28
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@mattmoor mattmoor Awaiting requested review from mattmoor

1 more reviewer

@navidshaikh navidshaikh navidshaikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

@navidshaikh navidshaikh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

e2e test fails if there are resouces created by the previous test

5 participants

@MIBc @knative-prow-robot @navidshaikh @mattmoor @googlebot