Show envFrom when running describe service or revision by MIBc · Pull Request #630 · knative/client

MIBc · 2020-02-01T04:42:06Z

Fixes #626

Proposed Changes

Show envFrom when running describe revison. The result like:
EnvFrom: ConfigMap:(testConfig), Secret:(testSecret)

Release Note:

🐛 Fix bug --env-from is not shown in service describe and revision describe #626 by showing envFrom when running describe revision.

knative-prow-robot · 2020-02-01T04:42:21Z

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhuss

Thanks a lot. I have one request for change of the output, but otherwise looks good.

Some other remarks:

Could you please add the changelog line directly into CHANGELOG.adoc and add it to the PR (as explained in the issue template) ?
Ideally we could already resolve the configmap or secret to the values they refer to, but I'm afraid that's not possible as we are no "allowed" to access configmaps/secrets via the K8s API. So having only the reference here is fine.

As a next step, we have to add this feature to kn service describe, too, for the currently active configuration, but also for all revisions (when use with --verbose)

rhuss · 2020-02-01T08:38:24Z

+		}
+	}
+	if len(configMap) > 0 {
+		result = append(result, fmt.Sprintf("ConfigMap:(%s)", strings.Join(configMap, ",")))


Can we please use the same format as it can be specified on the command line ? Ie. "cm:mymap" an "secret:mysecret" ? This helps to keep our wording consistent. (and you can better reuse it with copy&paste actions).

rhuss

thanks !

/lgtm

rhuss · 2020-02-01T18:19:00Z

@MIBc there is a minor formatting glitch which causes the test to fail. Could please fix that, then we are good to merge. Thank you.

MIBc · 2020-02-02T01:33:11Z

OK

Fixes knative#626 Show envFrom when running describe service or revison. The result like: EnvFrom: cm:test1, cm:test2

knative-prow-robot · 2020-02-02T03:17:24Z

@MIBc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

navidshaikh · 2020-02-02T03:19:10Z

/ok-to-test

On Sun, 2 Feb 2020 at 8:47 AM, Knative Prow Robot ***@***.***> wrote: @MIBc <https://github.com/MIBc>: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message. In response to this <#630 (comment)>: /retest Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#630?email_source=notifications&email_token=AATE22HW3EBWY2PKCTBD3ATRAY3MNA5CNFSM4KOQZHGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRMUIA#issuecomment-581093920>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATE22AJH2XLW7XTSH6VNS3RAY3MNANCNFSM4KOQZHGA> .

-- Navid Shaikh Composed on handheld device.

knative-metrics-robot · 2020-02-02T03:22:24Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/revision/describe.go	61.6%	63.8%	2.2
pkg/kn/commands/service/describe.go	79.6%	79.8%	0.1

knative-metrics-robot · 2020-02-02T03:22:24Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/revision/describe.go	61.6%	63.8%	2.2
pkg/kn/commands/service/describe.go	79.6%	79.8%	0.1

rhuss

thx !

/lgtm

knative-prow-robot · 2020-02-02T08:18:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Run `make generate-release` using openshift-knative/hack. Co-authored-by: dsimansk <dsimansk@users.noreply.github.com>

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 1, 2020

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2020

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2020

knative-prow-robot requested review from cppforlife and maximilien February 1, 2020 04:42

rhuss suggested changes Feb 1, 2020

View reviewed changes

MIBc force-pushed the envfrom branch from dc69906 to 73861f0 Compare February 1, 2020 12:39

MIBc changed the title ~~Show envFrom when running describe revision~~ Show envFrom when running describe service or revision Feb 1, 2020

rhuss approved these changes Feb 1, 2020

View reviewed changes

knative-prow-robot assigned rhuss Feb 1, 2020

knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2020

Show envFrom when running describe service or revision

d8089a4

Fixes knative#626 Show envFrom when running describe service or revison. The result like: EnvFrom: cm:test1, cm:test2

MIBc force-pushed the envfrom branch from 73861f0 to d8089a4 Compare February 2, 2020 02:43

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2020

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2020

rhuss approved these changes Feb 2, 2020

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2020

knative-prow-robot merged commit d82d557 into knative:master Feb 2, 2020

MIBc deleted the envfrom branch February 2, 2020 13:42

MIBc mentioned this pull request Aug 28, 2020

REQUEST: New membership for MIBc knative/community#243

Closed

markusthoemmes added a commit to markusthoemmes/knative-client that referenced this pull request Mar 8, 2021

Make the scripts use main instead of master (knative#630)

2e6b27f

dsimansk added a commit to dsimansk/client that referenced this pull request Apr 9, 2025

[release-v1.15] Run make generate-release (knative#630)

b6619ac

Run `make generate-release` using openshift-knative/hack. Co-authored-by: dsimansk <dsimansk@users.noreply.github.com>

Conversation

MIBc commented Feb 1, 2020

Proposed Changes

Uh oh!

knative-prow-robot commented Feb 1, 2020

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

rhuss Feb 1, 2020

Choose a reason for hiding this comment

Uh oh!

MIBc Feb 1, 2020

Choose a reason for hiding this comment

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

rhuss commented Feb 1, 2020

Uh oh!

MIBc commented Feb 2, 2020

Uh oh!

knative-prow-robot commented Feb 2, 2020

Uh oh!

navidshaikh commented Feb 2, 2020 via email

Uh oh!

knative-metrics-robot commented Feb 2, 2020

Uh oh!

knative-metrics-robot commented Feb 2, 2020

Uh oh!

rhuss left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Feb 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants