Fix capitalization of generated flags#638
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Feb 8, 2020
Merged
Conversation
Contributor
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@dsimansk: 0 warnings.
Details
In response to this:
Fixes #636
Proposed Changes
- When generating negative flag, change first character of original usage desc to lower case
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
size/S
Contributor
Author
|
/retest |
maximilien
approved these changes
Feb 6, 2020
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
Thanks for the contribution :)
/lgtm
knative-prow-robot
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Same error as in #640 , we should fix that flake somehow. |
Contributor
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
|
/retest |
Contributor
|
Again: I think has todo with BYO revision name feature (as the name here is clearly one that we generate on the client side.) From my feeling it looks like that the route is created before the revision has been established. |
Contributor
|
Flake should be fixed now with #644 /retest |
Contributor
|
/lgtm |
|
The following is the coverage report on the affected files.
|
Contributor
|
/retest |
dsimansk
pushed a commit
to dsimansk/client
that referenced
this pull request
Apr 17, 2025
This PR contains the following updates: | Package | Change | |---|---| | quay.io/konflux-ci/tekton-catalog/task-apply-tags | `61c90b1` -> `4973fa4` | | quay.io/konflux-ci/tekton-catalog/task-build-image-index | `95be274` -> `4d5ab47` | | quay.io/konflux-ci/tekton-catalog/task-buildah-remote-oci-ta | `1d26a89` -> `57a4a8b` | | quay.io/konflux-ci/tekton-catalog/task-git-clone-oci-ta | `9709088` -> `88367f7` | | quay.io/konflux-ci/tekton-catalog/task-init | `737682d` -> `38660e6` | | quay.io/konflux-ci/tekton-catalog/task-push-dockerfile-oci-ta | `55a4ff2` -> `6ad0ae8` | | quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan | `7b80f5a` -> `998b546` | | quay.io/konflux-ci/tekton-catalog/task-source-build-oci-ta | `9fe82c9` -> `f0e6c6f` | --- ### Configuration 📅 **Schedule**: Branch creation - "after 5am on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test`. This PR has been generated by [MintMaker](https://redirect.github.com/konflux-ci/mintmaker) (powered by [Renovate Bot](https://redirect.github.com/renovatebot/renovate)). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNTguMC1ycG0iLCJ1cGRhdGVkSW5WZXIiOiIzOS4xNTguMC1ycG0iLCJ0YXJnZXRCcmFuY2giOiJyZWxlYXNlLXYxLjE3IiwibGFiZWxzIjpbXX0=--> Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux-kflux-prd-rh02[bot] <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
dsimansk
pushed a commit
to dsimansk/client
that referenced
this pull request
Apr 17, 2025
This PR contains the following updates: | Package | Change | |---|---| | quay.io/konflux-ci/tekton-catalog/task-apply-tags | `61c90b1` -> `4973fa4` | | quay.io/konflux-ci/tekton-catalog/task-build-image-index | `95be274` -> `4d5ab47` | | quay.io/konflux-ci/tekton-catalog/task-buildah-remote-oci-ta | `1d26a89` -> `57a4a8b` | | quay.io/konflux-ci/tekton-catalog/task-git-clone-oci-ta | `9709088` -> `88367f7` | | quay.io/konflux-ci/tekton-catalog/task-init | `737682d` -> `38660e6` | | quay.io/konflux-ci/tekton-catalog/task-push-dockerfile-oci-ta | `55a4ff2` -> `6ad0ae8` | | quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan | `7b80f5a` -> `998b546` | | quay.io/konflux-ci/tekton-catalog/task-source-build-oci-ta | `9fe82c9` -> `f0e6c6f` | --- ### Configuration 📅 **Schedule**: Branch creation - "after 5am on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test`. This PR has been generated by [MintMaker](https://redirect.github.com/konflux-ci/mintmaker) (powered by [Renovate Bot](https://redirect.github.com/renovatebot/renovate)). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNTguMC1ycG0iLCJ1cGRhdGVkSW5WZXIiOiIzOS4xNTguMC1ycG0iLCJ0YXJnZXRCcmFuY2giOiJyZWxlYXNlLXYxLjE3IiwibGFiZWxzIjpbXX0=--> Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux-kflux-prd-rh02[bot] <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #636
Proposed Changes