fix(service wait): Wrong check for error window#661
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Feb 13, 2020
Merged
fix(service wait): Wrong check for error window#661knative-prow-robot merged 1 commit intoknative:masterfrom
knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
The error window introduced with knative#644 had a wrong conditional. Fixed that and added a test which would have detected this. Also, this should fix some issues which we tried to detect with knative#659.
knative-prow-robot
added
size/M
|
The following is the coverage report on the affected files.
|
Contributor
Author
|
@navidshaikh fix for a stupid error. btw, I'm not sure anymore whether the original flake really was a race in reconciliation, it looks more like an optimistic lock error. See knative/serving#6784 for tracking this. |
maximilien
approved these changes
Feb 12, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
Contributor
Author
|
/retest |
3 similar comments
Contributor
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error window introduced with #644 had a wrong conditional. Fixed that and added a test which would have detected this.
Also, this should fix some issues which we tried to detect with #659.