Verify "source ping describe" in ping e2e test#727
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Mar 11, 2020
Merged
Verify "source ping describe" in ping e2e test#727knative-prow-robot merged 1 commit intoknative:masterfrom
knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
knative-prow-robot
added
the
size/S
Contributor
|
@daisy-ycguo the test on |
knative-prow-robot
added
ok-to-test
Author
my mistake. I fixed in the latest version. tests are passed. please review. Thank you. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daisy-ycguo, maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dsimansk
pushed a commit
to dsimansk/client
that referenced
this pull request
Jul 28, 2021
This will allow the Jenkins jobs to use the actual return value of the script, instead of grepping through the output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verify ping source created correctly by "source ping describe" after "source ping create"
Changes
Reference
Fixes #566