Check DeleteTimestamp before updating resource

[MIBc]

Fixes: #786

Description

• Check DeleteTimestamp before updating resource. Include: service, apiserver source, sink binding, ping source, trigger.

Release Note:

• 🐛 Bug fix
  Check DeleteTimestamp before updating resource.

[knative-prow-robot]

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

/ok-to-test

[rhuss]

Thanks a lot for the PR, but beside some minor suggestion belows, I would go the full mile and implement this feature also for

• Revision
• ApiServer source
• Ping source
• SinkBinding

[maximilien]

I like @rhuss comment of doing same for other resources but I'd also be OK to merge more than one PR to make review and adoption easier.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, MIBc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MIBc]

/retest

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/source/apiserver/update.go	73.2%	74.4%	1.2
pkg/kn/commands/source/binding/update.go	74.4%	75.6%	1.1
pkg/kn/commands/source/ping/update.go	75.0%	76.3%	1.3
pkg/kn/commands/trigger/update.go	80.4%	81.1%	0.7
pkg/serving/v1/client.go	69.1%	68.4%	-0.8

[rhuss]

Thanks a lot ! One last think: Could you also add it to kn/commands/revision/delete.go ? I think then we are complete. If too much for now, i can also open an issue to track it and we merge it now.

[rhuss]

Let's get this merged and add the timestamp handling later to kn revision delete, too.

/lgtm