Skip to content

Check deletionTimestamp for "kn revision delete"#860

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
MIBc:deletionTimestamp
Jun 1, 2020
Merged

Check deletionTimestamp for "kn revision delete"#860
knative-prow-robot merged 2 commits intoknative:masterfrom
MIBc:deletionTimestamp

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented May 27, 2020

Fixes: #815

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 27, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 27, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2020
@rhuss
Copy link
Copy Markdown
Contributor

rhuss commented May 27, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
rhuss
rhuss reviewed May 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a minor wording suggestion.

Comment thread pkg/serving/v1/client.go Outdated
navidshaikh
navidshaikh suggested changes May 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should raise a waning here instead of returning an error / non-zero exit code.

Comment thread pkg/serving/v1/client.go Outdated
maximilien
maximilien suggested changes May 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any new tests?

Comment thread pkg/serving/v1/client.go Outdated
navidshaikh
navidshaikh reviewed Jun 1, 2020
View reviewed changes
Comment thread pkg/serving/v1/client.go Outdated
navidshaikh
navidshaikh reviewed Jun 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test all
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jun 1, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/serving/v1/client.go 68.4% 66.5% -1.9

@knative-prow-robot knative-prow-robot merged commit bcf2ec3 into knative:master Jun 1, 2020
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
dsimansk added a commit to dsimansk/client that referenced this pull request Nov 9, 2021
@dsimansk
Update spec file from latest release (knative#860)
da11cb6
dsimansk added a commit to dsimansk/client that referenced this pull request Oct 22, 2025
@serverless-qe @dsimansk
[release-v1.17] Update Konflux configurations (knative#860)
ae0ca3a 
Update Konflux components and pipelines

---------

Co-authored-by: serverless-qe <serverless-support@redhat.com>
Co-authored-by: David Simansky <dsimansk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

3 more reviewers

@rhuss rhuss rhuss left review comments

@navidshaikh navidshaikh navidshaikh requested changes

@maximilien maximilien maximilien requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@navidshaikh navidshaikh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Honour deletionTimestamp for "kn revision delete", too

7 participants

@MIBc @knative-prow-robot @rhuss @knative-metrics-robot @maximilien @navidshaikh @googlebot