Upgrade spf13/cobra dep to current master#944
Merged
Conversation
which includes the zsh completion fix for spf13/cobra#899 and remove the fork of cobra with fix in `replace` section of go.mod
Do not define and execute extractCommand before running actual root command to parse all the args without flags. This was creating issues with completion utils to generate additional shell completion directive. Now uses cobra's inbuilt utilities to parse the command args without flags.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
maximilien
suggested changes
Jul 22, 2020
Contributor
maximilien
left a comment
maximilien
left a comment
There was a problem hiding this comment.
Left some feedback. It's questionable if tests for main.go is needed... so do what you can.
Thanks for keeping us up to date with latest Cobra. Best.
daisy-ycguo
suggested changes
Jul 22, 2020
|
The following is the coverage report on the affected files.
|
Contributor
Author
|
/retest |
Contributor
|
OK thanks. /lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin cobra at v1.0.1-0.20200715031239-b95db644ed1c
Parse args without invoking a separate command
Do not define and execute extractCommand before running actual root
command to parse all the args without flags. This was creating issues
with completion utils to generate additional shell completion directive.
Now uses cobra's inbuilt utilities to parse the command args without flags.