Skip to content

Plugin inlining (backport)#991

Merged
knative-prow-robot merged 3 commits intoknative:release-0.16from
rhuss:pr/backport-inline-plugin
Aug 25, 2020
Merged

Plugin inlining (backport)#991
knative-prow-robot merged 3 commits intoknative:release-0.16from
rhuss:pr/backport-inline-plugin

Conversation

@rhuss
Copy link
Copy Markdown
Contributor

@rhuss rhuss commented Aug 25, 2020

This is a backport of #902

* chore: Add support for internal plugins

* added test for internal plugin lookup

* add changelog entry

* fix formatting

* update to latest changes on main

* Added more tests + some docs

* formatting fix

* moved to proper injection label for setting up the broker in integration test
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2020
Comment thread CHANGELOG.adoc Outdated

| 🎁
| Add support for internal plugins
| https://github.com/knative/client/pull/880[#880]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets update the date of the release (v0.16.1) as well ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhuss : also the PR number is #902

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right. going to fix it now.

@navidshaikh navidshaikh added the backport/pr A backport PR which is target to a release branch. label Aug 25, 2020
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@knative-prow-robot knative-prow-robot merged commit 0825919 into knative:release-0.16 Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/pr A backport PR which is target to a release branch. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants