-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Missing docs for cluster local setup #1402
Copy link
Copy link
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.kind/servinglifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/criticalsize/LDenotes a PR that changes 100-499 lines, ignoring generated files.Denotes a PR that changes 100-499 lines, ignoring generated files.
Milestone
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.kind/servinglifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/criticalsize/LDenotes a PR that changes 100-499 lines, ignoring generated files.Denotes a PR that changes 100-499 lines, ignoring generated files.
While going thru the setup for Istio-lean everything seems to work except intra-cluster communications between pods. Thanks to @ZhiminXiang for helping track down that the issue is that https://github.com/knative/docs/blob/master/docs/serving/cluster-local-route.md didn't include the step of adding:
to the
config-istioconfigMap. We should add that.Additionally, this section: https://github.com/knative/docs/blob/master/docs/install/installing-istio.md#updating-your-install-to-use-cluster-local-gateway has a pointer to the
cluster local routespage but the text there implies it's only needed for "cluster only" routes. So if we add the above configMap data to that page some people may miss it if they want both cluster-local and external routes. I would recommend putting the configMap steps on in this section: https://github.com/knative/docs/blob/master/docs/install/installing-istio.md#updating-your-install-to-use-cluster-local-gateway/cc @tcnghia