Skip to content

Registry doc: updating Kafka output and few other cosmetics#1311

Merged
knative-prow-robot merged 33 commits into
knative:masterfrom
nachocano:registry-docs
May 13, 2019
Merged

Registry doc: updating Kafka output and few other cosmetics#1311
knative-prow-robot merged 33 commits into
knative:masterfrom
nachocano:registry-docs

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented May 13, 2019

Fixes knative/eventing#929

Proposed Changes

  • This is a follow up on the other registry PR, as I updated the Kafka code, it outputs another source value.
  • Cosmetic changes to the rest of the doc.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 13, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @samodell
Sam this is a follow up PR. It seems more changes than it actually is. It should be an easy approve.
I updated the kafka output, and few other cosmetics in the text. Sockpuppet I think will take care of the formatting once this lands.

Comment thread docs/eventing/event-registry.md Outdated
Comment thread docs/eventing/event-registry.md Outdated
Comment thread docs/eventing/event-registry.md Outdated
Comment thread docs/eventing/event-registry.md Outdated
Comment thread docs/eventing/event-registry.md Outdated
@nachocano
Copy link
Copy Markdown
Contributor Author

@samodell done with the changes. I need to focus on some important code fixes.
IMO this can go in, and then we can keep on iterating. What do you think?

@samodell
Copy link
Copy Markdown
Contributor

Agreed! Thanks, @nachocano !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4effeea into knative:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event Registry

4 participants