Skip to content

Fix the wrong information in grpc example #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jun 1, 2019
Merged

Fix the wrong information in grpc example #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/serving/samples/grpc-ping-go/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ A simple gRPC server written in Go that you can use for testing.

## Prerequisites

- [Install the Knative Serving version 0.4 or later](../../../install/README.md).
- [Install the latest version of Knative Serving](../../../install/README.md).

- Install [docker](https://www.docker.com/).

Expand All @@ -22,7 +22,7 @@ First, build and publish the gRPC server to DockerHub (replacing `{username}`):
docker build \
--tag "docker.io/{username}/grpc-ping-go" \
--file=docs/serving/samples/grpc-ping-go/Dockerfile .
docker push "${REPO}/docs/serving/samples/grpc-ping-go"
docker push "docker.io/{username}/grpc-ping-go"
```

Next, replace `{username}` in `sample.yaml` with your DockerHub username, and
Expand Down