Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Dockerfile
README.md
**/obj/
**/bin/
9 changes: 9 additions & 0 deletions docs/serving/samples/hello-world/helloworld-csharp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ cd knative-docs/serving/samples/hello-world/helloworld-csharp
CMD ["dotnet", "out/helloworld-csharp.dll"]
```

1. Create a `.dockerignore` file to ensure that any files related to a local build do not affect the container that you build for deployment.

```ignore
Dockerfile
README.md
**/obj/
**/bin/
```

1. Create a new file, `service.yaml` and copy the following service definition
into the file. Make sure to replace `{username}` with your Docker Hub
username.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Dockerfile
README.md
node_modules
npm-debug.log
9 changes: 9 additions & 0 deletions docs/serving/samples/hello-world/helloworld-nodejs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,15 @@ cd knative-docs/serving/samples/hello-world/helloworld-nodejs
CMD [ "npm", "start" ]
```

1. Create a `.dockerignore` file to ensure that any files related to a local build do not affect the container that you build for deployment.

```ignore
Dockerfile
README.md
node_modules
npm-debug.log
```

1. Create a new file, `service.yaml` and copy the following service definition
into the file. Make sure to replace `{username}` with your Docker Hub
username.
Expand Down
3 changes: 3 additions & 0 deletions docs/serving/samples/hello-world/helloworld-php/.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Dockerfile
README.md
vendor
8 changes: 8 additions & 0 deletions docs/serving/samples/hello-world/helloworld-php/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ cd knative-docs/serving/samples/hello-world/helloworld-php
RUN mv "$PHP_INI_DIR/php.ini-development" "$PHP_INI_DIR/php.ini"
```

1. Create a `.dockerignore` file to ensure that any files related to a local build do not affect the container that you build for deployment.

```ignore
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichieEscarez

Is there any way to do some fancy server-side include magic here rather than needing to repeat the content?

Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the rendered content on the site, yes we have a few options (ie. using Hugo variables to inject chunks of content). the downside is that when the content is viewed in GitHub, its no longer legible (more difficult for authors or one-off contributors, especially those who use the GitHub WYSIWYG UI). im toying with the idea of getting our Netlify builds to run on demand (therefore the authoring process / PR review and merge steps would include running a "test build" to render and verify the output) but that too adds to the overhead of contributing. I think the first place we want to start to implement "content reuse" and "single sourcing" are for the multiple install guides

we should chat more if you have ideas here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the rendered content on the site, yes we have a few options (ie. using Hugo variables to inject chunks of content). the downside is that when the content is viewed in GitHub, its no longer legible (more difficult for authors or one-off contributors, especially those who use the GitHub WYSIWYG UI). im toying with the idea of getting our Netlify builds to run on demand (therefore the authoring process / PR review and merge steps would include running a "test build" to render and verify the output) but that too adds to the overhead of contributing. I think the first place we want to start to implement "content reuse" and "single sourcing" are for the multiple install guides

we should chat more if you have ideas here?

I would like something like SSI Include syntax:

<!--#include file="included.html" -->

Which seems like it would be fairly natural to read. But I don't know if Hugo has that capability.

Dockerfile
README.md
vendor
```

1. Create a new file, `service.yaml` and copy the following service definition
into the file. Make sure to replace `{username}` with your Docker Hub
username.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Dockerfile
README.md
*.pyc
*.pyo
*.pyd
__pycache__
11 changes: 11 additions & 0 deletions docs/serving/samples/hello-world/helloworld-python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,17 @@ cd knative-docs/serving/samples/hello-world/helloworld-python
CMD exec gunicorn --bind :$PORT --workers 1 --threads 8 app:app
```

1. Create a `.dockerignore` file to ensure that any files related to a local build do not affect the container that you build for deployment.

```ignore
Dockerfile
README.md
*.pyc
*.pyo
*.pyd
__pycache__
```

1. Create a new file, `service.yaml` and copy the following service definition
into the file. Make sure to replace `{username}` with your Docker Hub
username.
Expand Down