-
Notifications
You must be signed in to change notification settings - Fork 1.3k
service/samples: add .dockerignore to samples with local build disruption risk #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
knative-prow-robot
merged 6 commits into
knative:master
from
grayside:hello-dockerignore
May 31, 2019
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d7fa99
service/samples: add .dockerignore to samples with risk of local buil…
grayside 0d4f398
serving/samples: .dockerignore readme text update
grayside df2d8b4
Update docs/serving/samples/hello-world/helloworld-csharp/README.md
grayside 39c1211
Update docs/serving/samples/hello-world/helloworld-nodejs/README.md
grayside b0f9d60
Update docs/serving/samples/hello-world/helloworld-python/README.md
grayside e607e5e
Update docs/serving/samples/hello-world/helloworld-php/README.md
grayside File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
docs/serving/samples/hello-world/helloworld-csharp/.dockerignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Dockerfile | ||
| README.md | ||
| **/obj/ | ||
| **/bin/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
docs/serving/samples/hello-world/helloworld-nodejs/.dockerignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Dockerfile | ||
| README.md | ||
| node_modules | ||
| npm-debug.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
docs/serving/samples/hello-world/helloworld-php/.dockerignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Dockerfile | ||
| README.md | ||
| vendor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
docs/serving/samples/hello-world/helloworld-python/.dockerignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Dockerfile | ||
| README.md | ||
| *.pyc | ||
| *.pyo | ||
| *.pyd | ||
| __pycache__ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichieEscarez
Is there any way to do some fancy server-side include magic here rather than needing to repeat the content?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the rendered content on the site, yes we have a few options (ie. using Hugo variables to inject chunks of content). the downside is that when the content is viewed in GitHub, its no longer legible (more difficult for authors or one-off contributors, especially those who use the GitHub WYSIWYG UI). im toying with the idea of getting our Netlify builds to run on demand (therefore the authoring process / PR review and merge steps would include running a "test build" to render and verify the output) but that too adds to the overhead of contributing. I think the first place we want to start to implement "content reuse" and "single sourcing" are for the multiple install guides
we should chat more if you have ideas here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like something like SSI Include syntax:
Which seems like it would be fairly natural to read. But I don't know if Hugo has that capability.