Skip to content

Default channel for CRDs documentation#1619

Merged
knative-prow-robot merged 23 commits into
knative:masterfrom
nachocano:default-channel
Jul 31, 2019
Merged

Default channel for CRDs documentation#1619
knative-prow-robot merged 23 commits into
knative:masterfrom
nachocano:default-channel

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Jul 25, 2019

Fixes #1618

Proposed Changes

  • Added a new default-channels-crds.md to explain how the new default mechanism for channels work.

nachocano added 19 commits March 6, 2019 23:29
@nachocano
Adding bitbucket source documentation.
d6d469b
@nachocano
Adding README example for bitbucket source.
5a0f9e5
@nachocano
Updating example.
6e3b410
@nachocano
Merge remote-tracking branch 'upstream/master'
170a4a4
@nachocano
Missed to generate the README
2e79e48
@nachocano
Merge remote-tracking branch 'upstream/master'
811bc18
@nachocano
removing stuff, and updating link to bitbucket source in sources.yaml
eb41d97
@nachocano
Merge remote-tracking branch 'upstream/master'
2e2d576 
# Conflicts:
#	docs/eventing/sources/README.md
@nachocano
autogenerating README
f072535
@nachocano
removing bitbucket one here.
cdd196f
@nachocano
update
bdf2e56
@nachocano
Merge remote-tracking branch 'upstream/master'
fd50ed5
@nachocano
Merge remote-tracking branch 'upstream/master'
635afe1
@nachocano
Merge remote-tracking branch 'upstream/master'
31af4d0
@nachocano
Merge remote-tracking branch 'upstream/master'
d59ded4
@nachocano
Merge remote-tracking branch 'upstream/master'
af43942
@nachocano
Merge remote-tracking branch 'upstream/master'
fe45110
@nachocano
Merge remote-tracking branch 'upstream/master'
658d42c
@nachocano
default channels
9623dfb
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Jul 25, 2019

/cc @samodell

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 25, 2019
nachocano
nachocano commented Jul 25, 2019
View reviewed changes
Comment thread docs/eventing/channels/default-channels-crds.md Outdated
@@ -0,0 +1,92 @@
---
title: "Default channels"
Copy link
Copy Markdown
Contributor Author

@nachocano nachocano Jul 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samodell There is a defaults-channels.md which should be marked as deprecated in 0.8, and maybe point to this one? What is the procedure to properly do that?

Copy link
Copy Markdown
Contributor

@samodell samodell Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nachocano We don't really have a mechanism for redirects right now, as far as I know, but I'll check with Richie when he gets back from vacation. I think what we'll do is delete the deprecated file from the 0.8 release; it'll live on in the <0.7 versions.

Copy link
Copy Markdown
Contributor

@samodell samodell Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichieEscarez

This was referenced Jul 25, 2019
Merged
Closed
vaikas
vaikas reviewed Jul 26, 2019
View reviewed changes
Comment thread docs/eventing/channels/default-channels-crds.md Outdated
Comment thread docs/eventing/channels/default-channels-crds.md Outdated
Comment thread docs/eventing/channels/default-channels-crds.md Outdated
@knative-prow-robot knative-prow-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 29, 2019

/approve

Leaving lgtm for @samodell

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell samodell self-assigned this Jul 29, 2019
samodell
samodell reviewed Jul 29, 2019
View reviewed changes
Comment thread docs/eventing/channels/default-channels-crds.md Outdated
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Jul 31, 2019

@samodell BTW, let me know if you prefer to remove the default-channels.md as it is deprecated, and I can rename this file to have that name. Or you prefer to add a Deprecation note in the other one, and point to this one?

@samodell
Copy link
Copy Markdown
Contributor

samodell commented Jul 31, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@knative-prow-robot knative-prow-robot merged commit 31b5c78 into knative:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

2 more reviewers

@vaikas vaikas vaikas left review comments

@samodell samodell samodell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@samodell samodell

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document new Channel CRDs Default Mechanism

5 participants

@nachocano @vaikas @knative-prow-robot @samodell @googlebot