Skip to content

Issue 1977#1979

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
vaikas:issue-1977
Nov 12, 2019
Merged

Issue 1977#1979
knative-prow-robot merged 3 commits into
knative:masterfrom
vaikas:issue-1977

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Nov 12, 2019

Fixes #1977

Proposed Changes

  • Update examples for sequence/parallel to use flows.knative.dev instead of messaging.knative.dev
  • Add a pointer and a blurp about sequence/parallel to main Eventing Readme for easier discoverability.
  • update cronjobsource specs to reflect new Sink format (v1.destination duck).

@vaikas vaikas requested a review from lionelvillard November 12, 2019 12:10
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 12, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@vaikas: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check ae0ae70 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Nov 12, 2019

@samodell @RichieEscarez
I'm seeing the link check fail, and sure enough that file doesn't exist there? But when I look at the documentation on knative.dev that link does work, so is there some magic that happens somewhere or am I just holding it wrong?

docs/eventing/README.md
ERROR ../../contributing/WORKING-GROUPS.md#events
Stat contributing/WORKING-GROUPS.md: no such file or directory

@lionelvillard
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@knative-prow-robot knative-prow-robot merged commit 6178ad5 into knative:master Nov 12, 2019
@lionelvillard
Copy link
Copy Markdown
Contributor

WORKING-GROUPS.md is in knative/community. I guess the link check needs to either ignore contributing or better be done after fetching knative/community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the parallel,sequence to flows.knative.dev

4 participants