Skip to content

Update "Check ClusterIngress/Istio routing" in debugging-application-…#2049

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:master
Jan 6, 2020
Merged

Update "Check ClusterIngress/Istio routing" in debugging-application-…#2049
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:master

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Dec 13, 2019 •
edited
Loading

ClusterIngress has been deprecated. Update these contents with knative ingress.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 13, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Dec 13, 2019

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2019
@tcnghia
Copy link
Copy Markdown
Contributor

tcnghia commented Dec 20, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Dec 23, 2019

/assign @RichieEscarez

RichieEscarez
RichieEscarez suggested changes Dec 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and a few edits for clarity. PTAL
@tcnghia

Comment thread docs/serving/debugging-application-issues.md Outdated
details, see Knative
[Error Conditions and Reporting](https://github.com/knative/serving/blob/master/docs/spec/errors.md)(currently
[Error Conditions and Reporting](https://github.com/knative/docs/blob/master/docs/serving/spec/knative-api-specification-1.0.md#error-signalling)(currently
some of them are not implemented yet).
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"(currently some of them are not implemented yet)"

What does this mean (which ones)? The spec does not elaborate so it's unclear what is being referenced. Can this statement just be removed?

Copy link
Copy Markdown
Contributor Author

@MIBc MIBc Dec 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the error-signalling section and the relevant code. I can not find which one is not implemented. May be this could be removed.

Comment thread docs/serving/debugging-application-issues.md Outdated
Comment thread docs/serving/debugging-application-issues.md Outdated
Comment thread docs/serving/debugging-application-issues.md Outdated
Comment thread docs/serving/debugging-application-issues.md Outdated
Otherwise, there will be error messages.

Now, if ClusterIngress shows status Ready, there must be a corresponding
You can replace resource `ingresses.networking.internal.knative.dev` with `ClusterIngress` if you are using Knative release older than 0.9.
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to reference past versions. Our content is published by release and therefore, users of past versions should view the previous/corresponding doc set release.

Suggested change
You can replace resource `ingresses.networking.internal.knative.dev` with `ClusterIngress` if you are using Knative release older than 0.9.

Comment thread docs/serving/debugging-application-issues.md Outdated
@MIBc
Update "Check ClusterIngress/Istio routing" in debugging-application-…
19c1492 
…issues doc

ClusterIngress has been deprecated. Update these content with knative ingress.
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Dec 24, 2019

New changes are detected. LGTM label has been removed.

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Dec 24, 2019

Thanks for your suggestions. Please review. @RichieEscarez

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 5, 2020

Any other comments? @tcnghia @RichieEscarez

@RichieEscarez RichieEscarez added approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, RichieEscarez, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit bbda7cf into knative:master Jan 6, 2020
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@samodell samodell Awaiting requested review from samodell

1 more reviewer

@RichieEscarez RichieEscarez RichieEscarez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tcnghia tcnghia

@RichieEscarez RichieEscarez

Labels

cla: yes Indicates the PR's author has signed the CLA. kind/serving lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/needs-eng-input Engineering input is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MIBc @knative-prow-robot @tcnghia @RichieEscarez @googlebot