Skip to content

Cherry-pick #2296#2312

Merged
knative-prow-robot merged 1 commit intoknative:release-0.13from
evankanderson:cp
Mar 20, 2020
Merged

Cherry-pick #2296#2312
knative-prow-robot merged 1 commit intoknative:release-0.13from
evankanderson:cp

Conversation

@evankanderson
Copy link
Copy Markdown
Member

Fixes #2296 #2275

…urce more clear. (knative#2296)

* Fix typo in CronJobSource

* Fix paths after migration

* Update CronJobSource to indicate that it is deprecated and replaced by PingSource or CronJob + SinkBinding

* Update docs to not that ContainerSource is also deprecated
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 13, 2020
@knative-prow-robot knative-prow-robot added approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@evankanderson: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-docs-markdown-link-check 176adc3 link /test pull-knative-docs-markdown-link-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@n3wscott
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7da0dff into knative:release-0.13 Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants