Skip to content

Updating ContainerSource, Sources list, and migration example#2342

Merged
knative-prow-robot merged 13 commits intoknative:masterfrom
nachocano:container
Mar 27, 2020
Merged

Updating ContainerSource, Sources list, and migration example#2342
knative-prow-robot merged 13 commits intoknative:masterfrom
nachocano:container

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

Fixes #2332

Proposed Changes

  • Updated ContainerSource example.
  • Updated migration docs
  • Updated Sources list... Removed hardcoded spec fields. Those are part of the API reference and are generated.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 27, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2020
nachocano and others added 2 commits March 27, 2020 10:00
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
@nachocano nachocano changed the title Updating ContainerSource and migration examples Updating ContainerSource, Sources list, and migration example Mar 27, 2020
Comment thread docs/eventing/migration/sinkbinding.md
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @vaikas for approval powers

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@nachocano: GitHub didn't allow me to assign the following users: for, approval, powers.

Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @vaikas for approval powers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @vaikas
for approval powers

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Mar 27, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3c5fa60 into knative:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docs related to ContainerSource

6 participants