Skip to content

Update Docs to include new field ContainerStatus to the revision status#2405

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
savitaashture:newfieldupdate
Apr 29, 2020
Merged

Update Docs to include new field ContainerStatus to the revision status#2405
knative-prow-robot merged 1 commit intoknative:masterfrom
savitaashture:newfieldupdate

Conversation

@savitaashture
Copy link
Copy Markdown
Contributor

Background:
A new field has been added as part of the PR which is ContainerStatus to the revision status

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 21, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2020
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@savitaashture savitaashture changed the title Update Docs to include new field called ContainerStatus in the revision status Update Docs to include new field ContainerStatus to the revision status Apr 28, 2020
@evankanderson
Copy link
Copy Markdown
Member

/lgtm
/approve

I'm assuming that the API reference docs were generated via gen-api-reference-docs.sh?

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, matzew, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a7b0854 into knative:master Apr 29, 2020
@savitaashture
Copy link
Copy Markdown
Contributor Author

/lgtm
/approve

I'm assuming that the API reference docs were generated via gen-api-reference-docs.sh?

Sorry i dint use gen-api-reference-docs.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants