Remove periodSeconds from examples#2515
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Jun 5, 2020
antoineco:fix-routing-go-example
Merged
Remove periodSeconds from examples#2515knative-prow-robot merged 1 commit intoknative:masterfrom antoineco:fix-routing-go-example
knative-prow-robot merged 1 commit intoknative:masterfrom
antoineco:fix-routing-go-example
Conversation
Since knative/serving#4731, periodSeconds also requires failureThreshold and timeoutSeconds to be set.
knative-prow-robot
added
the
size/XS
Contributor
|
/lgtm |
Member
|
/lgtm |
Member
|
/approve |
Contributor
Author
|
/assign @carieshmarie @samodell @RichieEscarez |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoineco, csantanapr, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since knative/serving#4731,
periodSecondsalso requiresfailureThresholdandtimeoutSecondsto be set. The best is simply not to set it, otherwise our examples fail withadmission webhook "resource.webhook.serving.knative.dev" denied the request: mutation failed: expected 1 <= 0 <= 2147483647: spec.template.spec.containers[0].readinessProbe.failureThreshold, spec.template.spec.containers[0].readinessProbe.timeoutSecondsRef:
knative/serving#4780
knative/serving#5732