Add abrennan89 to doc-approvers#2579
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Jun 12, 2020
Merged
Conversation
abrennan89
added
the
do-not-merge/hold
knative-prow-robot
added
the
size/XS
abrennan89
requested review from
carieshmarie
and removed request for
RichieEscarez and
samodell
abrennan89
changed the title
knative-prow-robot
added
the
do-not-merge/work-in-progress
abrennan89
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
abrennan89
removed
the
do-not-merge/hold
Member
|
/lgtm |
Member
|
/approve The "major reviews" look good -- some of the commits ended up being small, but took a lot of work to adjust the initial PR to match the docs quality we expect. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From requirements
Reviewer of the codebase for at least 3 months
Primary reviewer for at least 10 substantial PRs to the codebase: Update contributing docs #2387 , Add the instructions on how to configure the operator CRs #2273 , Add instruction in how to install Knative with Knative operators #2261 , Update the Auto TLS instruction #2083 , Added Python Example for Knative Eventing #2299 , Blogging guidelines for Knative - Ready to publish #2523 , Update the instruction on how to use cluster local gateway #2090 , Add the documentation to the new scale-to-zero-pod-retention-period flag #2478 , [BLOG] Set up a local Knative environment up in no time flat #2546 , Source migrations #2275
Reviewed at least 30 PRs to the codebase: 37 PRs
Nominated by WG lead (no WG lead currently)