Skip to content

updating ApiServerSource example to use v1beta1#2688

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
capri-xiyue:apiserversource_v1beta1
Jul 20, 2020
Merged

updating ApiServerSource example to use v1beta1#2688
knative-prow-robot merged 1 commit into
knative:masterfrom
capri-xiyue:apiserversource_v1beta1

Conversation

@capri-xiyue
Copy link
Copy Markdown
Contributor

Fixes #2687
Helps with knative/eventing#3611

Proposed Changes

  • Updating ApiServerSource example to use v1beta1

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 17, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2020
@capri-xiyue
Copy link
Copy Markdown
Contributor Author

/hold until knative/eventing#3627 merged

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@capri-xiyue
Copy link
Copy Markdown
Contributor Author

/assign @lionelvillard @nachocano

@capri-xiyue
Copy link
Copy Markdown
Contributor Author

/test pull-knative-docs-integration-tests

@capri-xiyue
Copy link
Copy Markdown
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
Copy link
Copy Markdown
Contributor

@nachocano nachocano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor

/approve

/cc @abrennan89 FYI.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 22ef34a into knative:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ApiServerSource docs to use v1beta1

5 participants