Removed the Go path link from the ./eventing/event-delivery.md#3321
Conversation
|
Hi @Yashks1994. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| ## Common Delivery Parameters | ||
|
|
||
| The `delivery` value must be a [Delivery Spec](https://pkg.go.dev/knative.dev/eventing/pkg/apis/duck/v1?tab=doc#DeliverySpec) | ||
| The `delivery` value must be a Delivery Spec. |
There was a problem hiding this comment.
| The `delivery` value must be a Delivery Spec. | |
| The `delivery` value must be a Delivery Spec, which is a partial schema that is embedded in resources like `Broker`, `Trigger` and `Subscription`. | |
| ```yaml | |
| # DeadLetterSink is the sink receiving event that could not be sent to | |
| # a destination. | |
| deadLetterSink: | |
| ref: | |
| apiVersion: v1 | |
| kind: Service | |
| name: my-service | |
| uri: /my-path | |
| # Retry is the minimum number of retries the sender should attempt when | |
| # sending an event before moving it to the dead letter sink. | |
| retry: 5 | |
| // BackoffPolicy is the retry backoff policy (linear, exponential). | |
| backoffPolicy: exponential | |
| # BackoffDelay is the delay before retrying. | |
| # More information on Duration format: | |
| # - https://www.iso.org/iso-8601-date-and-time-format.html | |
| # - https://en.wikipedia.org/wiki/ISO_8601 | |
| # | |
| # For linear policy, backoff delay is backoffDelay*<numberOfRetries>. | |
| # For exponential policy, backoff delay is backoffDelay*2^<numberOfRetries>. | |
| backoffDelay: PT2S``` |
| In case of failure, the event is dropped and an error is logged into the system. | ||
|
|
||
| The `deadLetterSink` value must be a [Destination](https://pkg.go.dev/knative.dev/pkg/apis/duck/v1#Destination). | ||
| The `deadLetterSink` value must be a Destination. |
There was a problem hiding this comment.
Can you update the example below (line 87) by replacing <Destination> with the below YAML?
# DeadLetterSink is the sink receiving event that could not be sent to
# a destination.
deadLetterSink:
ref:
apiVersion: v1
kind: Service
name: my-service
uri: /my-pathThere was a problem hiding this comment.
Removed the existing yaml with the new one.
|
/assign @grantr |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #3309 - Remove links to Go code
Proposed Changes