Add context to network layer install section#3441
Conversation
knative-prow-robot
added
the
size/XS
|
/lgtm |
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
A few terminology commens, but I'm okay with the current language. If you want this to go in as-is, reply with /hold cancel. If you decide to make further changes, that will remove the /lgtm label and you'll need a re-review (and also to cancel the hold).
/approve
/hold
|
|
||
| ## Install a networking layer | ||
|
|
||
| The networking layer in Knative Serving routes incoming and outgoing traffic for your Knative installation. |
There was a problem hiding this comment.
I'd sort of prefer to refer to this as "HTTP router" or "HTTP ingress" (it's more precise, and avoids confusion with e.g. Kubernetes CNI layer).
The networking layer in question here is responsible for incoming requests and the associated responses. It doesn't do anything for outbound traffic from the user containers.
There was a problem hiding this comment.
Thanks @evankanderson for your suggestions. Would it make sense for me to change the wording to something like:
The networking layer in Knative Serving is responsible for incoming requests and the associated responses for your Knative installation.
There was a problem hiding this comment.
Yep, that makes sense, and avoids needing to rewrite a lot more docs.
knative-prow-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
knative-prow-robot
added
size/S
|
/lgtm |
4 participants
Closes #3377