Skip to content

Move eventing samples to index.md#3470

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
evankanderson:index-eventing-samples
Apr 19, 2021
Merged

Move eventing samples to index.md#3470
knative-prow-robot merged 1 commit into
knative:mainfrom
evankanderson:index-eventing-samples

Conversation

@evankanderson
Copy link
Copy Markdown
Member

Remove README.md file includes for docs/eventing/samples. I'm breaking these up inot several PRs to make it easier to avoid conflicts / hold off on PRs that would have a conflict.

Proposed Changes

  • Inline README.md files that are included via {{readfile}} shortcodes.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 17, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 17, 2021
@evankanderson
Copy link
Copy Markdown
Member Author

/approve
/assign @julz @abrennan89

(I'm assuming this makes mkdocs migration no harder and may simplify things overall.)

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2021
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants