background gradient animation for homepage banner#3556
Merged
knative-prow-robot merged 1 commit intoMay 12, 2021
Conversation
knative-prow-robot
added
the
size/M
|
/lgtm Thanks for including a link to your personal GitHub page! Super useful, especially for stuff like this :) |
|
CC: @csantanapr @julz |
Signed-off-by: Fabian Lopez <lfabian@vmware.com>
leetcope
force-pushed
the
homepage-gradient-animation
branch
from
ba8ab33 to
d5ea28c
Compare
|
Let me know when you're done making changes and I can /lgtm and find someone to approve 😃 |
Contributor
Author
|
@omerbensaadon it's the last one, I swear ✋ just cleaning up the code a little bit |
|
/lgtm |
Contributor
|
🔥 🔥 sweeeet! |
omerbensaadon
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
RichardJJG
pushed a commit
to RichardJJG/docs
that referenced
this pull request
Jun 30, 2021
Signed-off-by: Fabian Lopez <lfabian@vmware.com>
RichardJJG
pushed a commit
to RichardJJG/docs
that referenced
this pull request
Jul 1, 2021
Signed-off-by: Fabian Lopez <lfabian@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes