(eventing helloworld-python) add missing Broker and reformat YAML#3680
(eventing helloworld-python) add missing Broker and reformat YAML#3680boramalper wants to merge 1 commit into
Conversation
Signed-off-by: Bora M. Alper <bora@boramalper.org>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: boramalper The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @boramalper! It looks like this is your first PR to knative/docs 🎉 |
|
Hi @boramalper. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
✔️ Deploy Preview for dev-knative ready! 🔨 Explore the source changes: 2a2364f 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60af9d3f71e5500007a4329f 😎 Browse the preview: https://deploy-preview-3680--dev-knative.netlify.app/development/eventing/samples/helloworld/helloworld-python |
|
@googlebot I signed it! |
|
See my comments on #3682 (review) |
|
I believe these changes have already been made in #3682 |
|
@boramalper: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Bora M. Alper bora@boramalper.org
Fixes #3653.
Proposed Changes