Skip to content

(eventing helloworld-python) add missing Broker and reformat YAML#3680

Closed
boramalper wants to merge 1 commit into
knative:mkdocsfrom
boramalper:new-eventing-helloworld-python
Closed

(eventing helloworld-python) add missing Broker and reformat YAML#3680
boramalper wants to merge 1 commit into
knative:mkdocsfrom
boramalper:new-eventing-helloworld-python

Conversation

@boramalper
Copy link
Copy Markdown

Signed-off-by: Bora M. Alper bora@boramalper.org

Fixes #3653.

Proposed Changes

  • Add missing Broker
  • Reformat YAML
  • Remove the username in the Docker image URL

Signed-off-by: Bora M. Alper <bora@boramalper.org>
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: boramalper
To complete the pull request process, please assign devguyio after the PR has been reviewed.
You can assign the PR to them by writing /assign @devguyio in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla Bot added the cla: no Indicates the PR's author has not signed the CLA. label May 27, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Welcome @boramalper! It looks like this is your first PR to knative/docs 🎉

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @boramalper. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 2a2364f

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60af9d3f71e5500007a4329f

😎 Browse the preview: https://deploy-preview-3680--dev-knative.netlify.app/development/eventing/samples/helloworld/helloworld-python

@boramalper
Copy link
Copy Markdown
Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels May 27, 2021
@abrennan89
Copy link
Copy Markdown
Contributor

/ok-to-test

@vaikas is this one duplicating any work from #3682?

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2021
@abrennan89 abrennan89 requested a review from vaikas June 1, 2021 13:48
@csantanapr
Copy link
Copy Markdown
Member

See my comments on #3682 (review)

@abrennan89
Copy link
Copy Markdown
Contributor

I believe these changes have already been made in #3682
@boramalper you may want to rebase your PR and see if there's anything else in this PR that changed, otherwise I think this one can be closed?

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@boramalper: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2021
@boramalper boramalper closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

4 participants