add docker development workflow#3738
Conversation
Signed-off-by: Carlos Santana <csantana23@gmail.com>
|
✔️ Deploy Preview for dev-knative ready! 🔨 Explore the source changes: c0f038c 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60badedb7933ca0008d85932 😎 Browse the preview: https://deploy-preview-3738--dev-knative.netlify.app |
Signed-off-by: Carlos Santana <csantana23@gmail.com>
julz
left a comment
There was a problem hiding this comment.
Just to check I understand the reasoning, could we not ship a pre-built docker image with the deps installed and avoid docs writers having to have node/npm installed (and the build step)?
No reason why we can't use a prebuilt image. How do I do that in this PR? |
|
+ 1 to pre-built image, not sure if I did a good job of specifying that in
the story…
…On Mon, Jun 7, 2021 at 2:57 PM Carlos Santana ***@***.***> wrote:
Just to check I understand the reasoning, could we not ship a pre-built
docker image with the deps installed and avoid docs writers having to have
node/npm installed (and the build step)?
No reason why we can't use a prebuilt image. How do I do that in this PR?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#3738 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4G5HXF6FSODYWXZMJEOYTTRUJCDANCNFSM46D52XMQ>
.
|
|
A pre-built image is a good idea, we just need to work with someone that knows how the infra/prow works to be able to push an image with a nightly job I propose we merge this PR and an issue is already created for the pre-built image #3664 |
julz
left a comment
There was a problem hiding this comment.
We'll figure out the image later since we need to work out what repo to put it in
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csantanapr, julz, omerbensaadon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add docker development workflow Signed-off-by: Carlos Santana <csantana23@gmail.com> * adding pesky EOL Signed-off-by: Carlos Santana <csantana23@gmail.com>
Closes #3664
Provides a simple workflow for mkdocs
Do once to build the container
To start working on docs (instant livereload using a container)
When done working on docs
cc @abrennan89 @RichardJJG @snneji
/kind mkdocs
/assign @julz
/assign @omerbensaadon