Skip to content

fix fixing nav item colors#3764

Merged
knative-prow-robot merged 1 commit into
knative:mkdocsfrom
gabo1208:nav-link-fixes
Jun 10, 2021
Merged

fix fixing nav item colors#3764
knative-prow-robot merged 1 commit into
knative:mkdocsfrom
gabo1208:nav-link-fixes

Conversation

@gabo1208
Copy link
Copy Markdown
Member

@gabo1208 gabo1208 commented Jun 9, 2021

fixes #3763

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 9, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 9, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 9, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 36c6c99

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60c0fce135adf50008d67da6

😎 Browse the preview: https://deploy-preview-3764--dev-knative.netlify.app

@omerbensaadon
Copy link
Copy Markdown

omerbensaadon commented Jun 10, 2021

Oh hey, this highlights in blue where you currently are on the page, not sure it did that before but it's really nice!

Thanks @gabo1208 :)

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, omerbensaadon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@knative-prow-robot knative-prow-robot merged commit 47ce045 into knative:mkdocs Jun 10, 2021
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
@gabo1208 @RichardJJG
fix fixing nav item colors (knative#3764)
fbf65d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@omerbensaadon omerbensaadon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The left nav links are showing up as different colors

3 participants

@gabo1208 @omerbensaadon @knative-prow-robot