h4 tag change in font weight for fixing issue (#3696)

[doitpratik]

Proposed Changes

• changed font weight for h4 tag similar value with other heading tag like h3.
• For fixing issue Update style for H4 headings #3696

[knative-prow-robot]

Hi @soham283. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 187608b

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60dcbd3d3544a70007277768

😎 Browse the preview: https://deploy-preview-3767--dev-knative.netlify.app

[omerbensaadon]

CC @snneji @csantanapr

[julz]

font-weight: 400 is the same as normal text (see https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#values), so Im not sure this is really an improvement :(.

[doitpratik]

The #3696 issue it was stated that bold text and h4 tags context must have distinct style so that it can be recognized easily
that's why I came up with this

[julz]

yes, but this makes it so that the h4 tags are impossible to distinguish from regular text, which is even worse than being hard to distinguish from bold text?

[doitpratik]

maybe increasing font-size may work. initially i thinked about that, but also thought if styling can make difference

[doitpratik]

Now updated the commit by changing font size, and removed font weight which were making is difficult to differentiate with the normal text.
@snneji @julz @omerbensaadon
have a look on the new commit made

[snneji]

Hi @soham283, thanks for working on this!

I think 1.0rem H4 font size looks a bit too large and heavy compared to H3 headings. I did a few tests in my browser. My personal preference is ~0.88rem. I was split between having the standard or a lighter font weight. My preferences are as follows:

• For the standard font weight (700), I prefer the H4 font size to be between 0.86 and 0.88 rem. Example page:
  
  

• For a lighter font weight (400), I prefer the H4 font size to be a bit larger — between 0.88 and 0.9 rem. Example page:
  
  

I suppose this is a matter of personal taste so feel free to disagree @soham283, @julz, and @omerbensaadon!

[csantanapr]

@snneji can you take another look when you have a chance?

[snneji]

/lgtm

[julz]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, soham283

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [julz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment