Skip to content

[WIP] #3078: Clean up Kafka docs#3781

Closed
abrennan89 wants to merge 1 commit into
knative:mkdocsfrom
abrennan89:3078
Closed

[WIP] #3078: Clean up Kafka docs#3781
abrennan89 wants to merge 1 commit into
knative:mkdocsfrom
abrennan89:3078

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 commented Jun 10, 2021

Fixes #3078

Proposed Changes

  • Remove outdated script and Kafka install steps (no longer working, very old version used) and add links to Strimzi docs instead.
  • TBA

/hold
This is WIP

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 10, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 10, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 10, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 4f6fe9b

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60c2993ff8f37f00071e5987

😎 Browse the preview: https://deploy-preview-3781--dev-knative.netlify.app

@taiju taiju mentioned this pull request Jun 11, 2021
Closed
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 12, 2021

@abrennan89: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2021
@abrennan89 abrennan89 closed this Jun 16, 2021
This was referenced Sep 5, 2021
Open
Open
Open
Open
@abrennan89 abrennan89 deleted the 3078 branch August 26, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apache Kafka Channel Example(docs/eventing/samples/kafka/channel/index.md) simplification

2 participants

@abrennan89 @knative-prow-robot